linux-kernel - Re: [PATCH] crypto: ccp: do not request interrupt on cmd completion when irqs disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZtqqLSNSYpsD5Cgy@gondor.apana.org.au>
Date: Fri, 6 Sep 2024 15:07:25 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Amit Shah <amit@...nel.org>
Cc: ashish.kalra@....com, thomas.lendacky@....com, bp@...en8.de,
	john.allen@....com, davem@...emloft.net, michael.roth@....com,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	amit.shah@....com
Subject: Re: [PATCH] crypto: ccp: do not request interrupt on cmd completion
 when irqs disabled

On Thu, Aug 29, 2024 at 12:20:07PM +0200, Amit Shah wrote:
> From: Amit Shah <amit.shah@....com>
> 
> While sending a command to the PSP, we always requested an interrupt
> from the PSP after command completion.  This worked for most cases.  For
> the special case of irqs being disabled -- e.g. when running within
> crashdump or kexec contexts, we should not set the SEV_CMDRESP_IOC flag,
> so the PSP knows to not attempt interrupt delivery.
> 
> Fixes: 8ef979584ea8 ("crypto: ccp: Add panic notifier for SEV/SNP firmware shutdown on kdump")
> 
> Based-on-patch-by: Tom Lendacky <thomas.lendacky@....com>
> Signed-off-by: Amit Shah <amit.shah@....com>
> ---
>  drivers/crypto/ccp/sev-dev.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt