linux-kernel - Re: [PATCH] Input: goodix-berlin - Fix VDDIO regulator name according to dt-bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b4573018-365f-4ce4-9452-6fc7adae3f3e@linaro.org>
Date: Fri, 6 Sep 2024 09:59:12 +0200
From: neil.armstrong@...aro.org
To: Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Danila Tikhonov <danila@...xyga.com>
Cc: hadess@...ess.net, hdegoede@...hat.com, jeff@...undy.com,
 krzk@...nel.org, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux@...nlining.org
Subject: Re: [PATCH] Input: goodix-berlin - Fix VDDIO regulator name according
 to dt-bindings

Hi,

On 06/09/2024 07:29, Dmitry Torokhov wrote:
> Hi Danila,
> 
> On Mon, Aug 05, 2024 at 06:58:06PM +0300, Danila Tikhonov wrote:
>> The dt-bindings specify the regulator as "vddio" instead of "iovdd".
>>
>> This patch fixes the regulator name from "iovdd" to "vddio" in the
>> driver code to align with the dt-bindings. Fixing the dt-bindings
>> would break ABI, hence the fix is made in the driver instead.
>>
>> There are no users of this regulator сurrently.
> 
> If there are no users (and the binding is pretty new) we should consider
> all options. Do you know the name of the supply in the datasheet?

The names comes from the downstream driver & bindings, but we don't
declare them on the Qualcomm platforms using the berlin touch ICs.

Perhaps someone from Goodix or someone with access to datasheet could confirm...

Anyway, this aligns with bindings so it's a correct patch.

Neil

> 
> Thanks.
>