linux-kernel - Re: [PATCH v2 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240906081005.69334-1-amadeus@jmu.edu.cn>
Date: Fri,  6 Sep 2024 16:10:05 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: bigfoot@...ssfun.cn
Cc: amadeus@....edu.cn,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dsimic@...jaro.org,
	heiko@...ech.de,
	jonas@...boo.se,
	krzk+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

Hi Junhao,

> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> @@ -0,0 +1,595 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/soc/rockchip,vop2.h>
> +#include <dt-bindings/soc/rockchip,boot-mode.h>

No need for input.h, leds/common.h and boot-mode.h.

> +#include "rk3568.dtsi"
> ...
> +	vcc3v3_sd: regulator-3v3-vcc-sd {
> +		pinctrl-0 = <&vcc_sd_h>;

schematics: sdmmc0_pwren

> ...
> +	vcc3v3_rf: regulator-3v3-vcc-rf {

schematics: VCC3V4_RF
VCCIN_5V -> VCC3V4_RF

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vcc3v3_rf_pwren_en>;

schematics: RF_PWR_EN

> ...
> +	vcc5v0_sysin: regulator-5v0-vcc-sysin {

schematics: VCC_SYSIN

> ...
> +	vcc5v0_syson: regulator-5v0-vcc-syson {

schematics: VCC_SYSON

> ...
> +	vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host {
> ...
> +		vin-supply = <&vcc5v0_syson>;

VCCIN_5V -> VCC5V0_USB30_OTG0

> ...
> +&gmac1 {
> ...
> +	tx_delay = <0x0>;
> +	rx_delay = <0x0>;

Please remove the tx_delay and rx_delay, it's useless.
I know there is an error log, but please ignore it first.

> ...
> +&pinctrl {
> ...
> +		bt_reg_on_h: bt-enable-h {
> +		pcie_pwren_h: pcie-enable-h {
> +		wifi_reg_on_h: wifi-enable-h {
> +		vcc3v3_rf_pwren_en: vcc5v0-modem-en {
> +		usb_host_pwren_h: vcc5v0-host-en {

obviously (

> +	wifi_pwrseq: wifi-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> ...
> +&pinctrl {
> ...
> +	sdio-pwrseq {

I tend to write like this:

```
&pinctrl {
	wifi {
		wifi_reg_on_h: wifi-reg-on-h {
```

> +	vcc_sd {
> +		vcc_sd_h: vcc-sd-h {

Overwrite original to match `sdmmc0_pwren`

sdmmc0 {
	sdmmc0_pwren: sdmmc0-pwren {

> +			rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +

Extra blank lines.

> +};
> ...
> &sdmmc1 {
> ...
> 	max-frequency = <150000000>;

`max-frequency = <150000000>;` already defined in rk356x.dtsi

> ...
> +&usb_host0_ohci {
> ...
> +&usb_host0_ehci {

&usb_host0_ehci {
&usb_host0_ohci {

Same for usb_host1

> ...
> &usb2phy1_host {
> 	phy-supply = <&vcc3v3_rf>;
> 	status = "okay";
> };

Is usb2phy1_host connected?

-- 
2.25.1