linux-kernel - Re: [PATCH] riscv: Remove unused GENERATING_ASM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAfSe-uyHNmMU97ZtsSYpUDw4shPx+v32tCY3j3vu2dweOCppA@mail.gmail.com>
Date: Fri, 6 Sep 2024 09:34:53 +0800
From: Chunyan Zhang <zhang.lyra@...il.com>
To: Palmer Dabbelt <palmer@...belt.com>
Cc: Chunyan Zhang <zhangchunyan@...as.ac.cn>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Albert Ou <aou@...s.berkeley.edu>, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Alexandre Ghiti <alex@...ti.fr>
Subject: Re: [PATCH] riscv: Remove unused GENERATING_ASM_OFFSETS

On Fri, 16 Aug 2024 at 20:30, Alexandre Ghiti <alex@...ti.fr> wrote:
>
> Hi Chunyan,
>
> On 16/08/2024 12:19, Chunyan Zhang wrote:
> > The macro is not used in the current version of kernel, it looks like
> > can be removed to avoid a build warning:
> >
> > ../arch/riscv/kernel/asm-offsets.c: At top level:
> > ../arch/riscv/kernel/asm-offsets.c:7: warning: macro "GENERATING_ASM_OFFSETS" is not used [-Wunused-macros]
> >      7 | #define GENERATING_ASM_OFFSETS
>
> So this warning never shows up in a "normal" kernel compilation, but it
> happens when using W=2 (with quite a lot of other warnings).
>
> This unused define indeed seems completely useless, I guess not all
> unused defines fall into this category and we should be careful when
> removing them, but for this one it makes sense so:
>
> Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>
> Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>

I think this should be ready to be merged.

Palmer, would you please pick this up to your tree? Or I can resend
the patch if that's more convenient for you.

Thanks,
Chunyan

>
> Thanks,
>
> Alex
>
>
> >
> > Fixes: 9639a44394b9 ("RISC-V: Provide a cleaner raw_smp_processor_id()")
> > Signed-off-by: Chunyan Zhang <zhangchunyan@...as.ac.cn>
> > ---
> >   arch/riscv/kernel/asm-offsets.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/riscv/kernel/asm-offsets.c b/arch/riscv/kernel/asm-offsets.c
> > index b09ca5f944f7..cb09f0c4f62c 100644
> > --- a/arch/riscv/kernel/asm-offsets.c
> > +++ b/arch/riscv/kernel/asm-offsets.c
> > @@ -4,8 +4,6 @@
> >    * Copyright (C) 2017 SiFive
> >    */
> >
> > -#define GENERATING_ASM_OFFSETS
> > -
> >   #include <linux/kbuild.h>
> >   #include <linux/mm.h>
> >   #include <linux/sched.h>