lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <22a622cd-5f10-58cf-92e8-be3da31e127c@gmail.com> Date: Fri, 6 Sep 2024 12:49:51 +0300 From: Sergei Shtylyov <sergei.shtylyov@...il.com> To: Ma Ke <make24@...as.ac.cn>, linus.walleij@...aro.org, mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com, bartosz.golaszewski@...aro.org, antonio.borneo@...s.st.com, valentin.caron@...s.st.com, peng.fan@....com, akpm@...ux-foundation.org Cc: linux-gpio@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH v2] pinctrl: stm32: check devm_kasprintf() returned value On 9/6/24 5:03 AM, Ma Ke wrote: > devm_kasprintf() can return a NULL pointer on failure but this returned > value is not checked. Fix this lack and check the returned value. > > Found by code review. > > Cc: stable@...r.kernel.org > Fixes: 32c170ff15b0 ("pinctrl: stm32: set default gpio line names using pin names") > Signed-off-by: Ma Ke <make24@...as.ac.cn> [...] > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index a8673739871d..f23b081f31b3 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -1374,10 +1374,16 @@ static int stm32_gpiolib_register_bank(struct stm32_pinctrl *pctl, struct fwnode > > for (i = 0; i < npins; i++) { > stm32_pin = stm32_pctrl_get_desc_pin_from_gpio(pctl, bank, i); > - if (stm32_pin && stm32_pin->pin.name) > + if (stm32_pin && stm32_pin->pin.name) { > names[i] = devm_kasprintf(dev, GFP_KERNEL, "%s", stm32_pin->pin.name); > - else > + if (!names[i]) { > + err = -ENOMEM; > + goto err_clk; > + } > + } > + > + else { No, that should be: } else { See Documentation/process/coding-style.rst, section 3. > names[i] = NULL; > + } > } [...] MBR, Sergey
Powered by blists - more mailing lists