[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5c8b066c-6e61-44c1-b99d-4ae1a2313033@kernel.org>
Date: Fri, 6 Sep 2024 11:53:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Junhao Xie <bigfoot@...ssfun.cn>, devicetree@...r.kernel.org,
linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, linux-pm@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@....cz>,
Lee Jones <lee@...nel.org>, Sebastian Reichel <sre@...nel.org>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>, Heiko Stuebner <heiko@...ech.de>,
Chukun Pan <amadeus@....edu.cn>
Subject: Re: [PATCH 9/9] arm64: dts: rockchip: add Photonicat PMU support for
Ariaboard Photonicat
On 06/09/2024 11:36, Junhao Xie wrote:
> This commit adds support for Photonicat power management MCU on
> Ariaboard Photonicat.
>
> Signed-off-by: Junhao Xie <bigfoot@...ssfun.cn>
> ---
> .../boot/dts/rockchip/rk3568-photonicat.dts | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> index 2fe403cd61cb..597275702408 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> @@ -513,6 +513,49 @@ &uart4 {
> dma-names = "tx", "rx";
> status = "okay";
> /* Onboard power management MCU */
> +
> + pcat_pmu: mcu {
> + compatible = "ariaboard,photonicat-pmu";
> + current-speed = <115200>;
> + local-address = <1>;
> + remote-address = <1>;
> +
> + pcat_pmu_battery: supply-battery {
Drop unused labels. Everywhere. You are not making the code more readable.
> + compatible = "ariaboard,photonicat-pmu-supply";
> + label = "battery";
> + monitored-battery = <&battery>;
> + power-supplies = <&pcat_pmu_charger>;
Why do you reference internal design of the device as DTS? You cannot
have here other power supply, can you?
Best regards,
Krzysztof
Powered by blists - more mailing lists