lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <742ccba0-6a27-7694-2381-37a70c137ac5@huaweicloud.com> Date: Fri, 6 Sep 2024 19:44:26 +0800 From: Zhang Yi <yi.zhang@...weicloud.com> To: Jan Kara <jack@...e.cz> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, ritesh.list@...il.com, yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com Subject: Re: [PATCH -next] ext4: don't pass full mapping flags to ext4_es_insert_extent() On 2024/9/6 18:34, Jan Kara wrote: > On Fri 06-09-24 14:14:01, Zhang Yi wrote: >> From: Zhang Yi <yi.zhang@...wei.com> >> >> When converting a delalloc extent in ext4_es_insert_extent(), since we >> only want to pass the info of whether the quota has already been claimed >> if the allocation is a direct allocation from ext4_map_create_blocks(), >> there is no need to pass full mapping flags, so changes to just pass >> whether the EXT4_GET_BLOCKS_DELALLOC_RESERVE bit is set. >> >> Suggested-by: Jan Kara <jack@...e.cz> >> Signed-off-by: Zhang Yi <yi.zhang@...wei.com> > > Looks good. Feel free to add: > > Reviewed-by: Jan Kara <jack@...e.cz> > >> @@ -863,8 +863,8 @@ void ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk, >> if (EXT4_SB(inode->i_sb)->s_mount_state & EXT4_FC_REPLAY) >> return; >> >> - es_debug("add [%u/%u) %llu %x %x to extent status tree of inode %lu\n", >> - lblk, len, pblk, status, flags, inode->i_ino); >> + es_debug("add [%u/%u) %llu %x %d to extent status tree of inode %lu\n", >> + lblk, len, pblk, status, delalloc_reserve_used, inode->i_ino); > > Ah, I didn't know 'bool' gets automatically promoted to 'int' when passed > as variadic argument but it seems to be the case from what I've found. One > always learns :) > Yeah, I'm always learn too. ;) Thanks, Yi.
Powered by blists - more mailing lists