linux-kernel - Re: [PATCH 7/9] x86: vdso: Modify asm/vdso/getrandom.h to include datapage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d11332c-1575-419c-af49-de9cb36dcabf@arm.com>
Date: Fri, 6 Sep 2024 12:48:14 +0100
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
 linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, linux-mm@...ck.org
Cc: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 "Jason A . Donenfeld" <Jason@...c4.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H . Peter Anvin" <hpa@...or.com>, Theodore Ts'o <tytso@....edu>,
 Arnd Bergmann <arnd@...db.de>, Andrew Morton <akpm@...ux-foundation.org>,
 Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH 7/9] x86: vdso: Modify asm/vdso/getrandom.h to include
 datapage

On 04/09/2024 18:19, Christophe Leroy wrote:
> 
> 
> Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit :
>> The VDSO implementation includes headers from outside of the
>> vdso/ namespace.
>>
>> Modify asm/vdso/getrandom.h to include datapage.
> 
> Does  asm/vdso/getrandom.h need datapage ? If not it is the ones that need it
> that should include it.
>

Why do you think it does not need it?

>>
>> Cc: Andy Lutomirski <luto@...nel.org>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Jason A. Donenfeld <Jason@...c4.com>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
>> ---
>>   arch/x86/include/asm/vdso/getrandom.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/include/asm/vdso/getrandom.h
>> b/arch/x86/include/asm/vdso/getrandom.h
>> index ff5334ad32a0..4597d5a6f094 100644
>> --- a/arch/x86/include/asm/vdso/getrandom.h
>> +++ b/arch/x86/include/asm/vdso/getrandom.h
>> @@ -7,6 +7,8 @@
>>     #ifndef __ASSEMBLY__
>>   +#include <vdso/datapage.h>
>> +
>>   #include <asm/unistd.h>
>>   #include <asm/vvar.h>
>>   

-- 
Regards,
Vincenzo