linux-kernel - Re: [PATCH v3 04/29] media: iris: initialize power resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7fd8c50-d5d9-4210-8253-457d7523eb30@kernel.org>
Date: Fri, 6 Sep 2024 14:04:39 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vikash Garodia <quic_vgarodia@...cinc.com>,
 Dikshita Agarwal <quic_dikshita@...cinc.com>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 04/29] media: iris: initialize power resources

On 06/09/2024 13:21, Vikash Garodia wrote:
>>>>
>>>>> +	}
>>>>> +
>>>>>  	ret = v4l2_device_register(dev, &core->v4l2_dev);
>>>>>  	if (ret)
>>>>>  		return ret;
>>>>> @@ -88,8 +101,14 @@ static int iris_probe(struct platform_device *pdev)
>>>>>  }
>>>>>  
>>>>>  static const struct of_device_id iris_dt_match[] = {
>>>>> -	{ .compatible = "qcom,sm8550-iris", },
>>>>> -	{ .compatible = "qcom,sm8250-venus", },
>>>>> +	{
>>>>> +		.compatible = "qcom,sm8550-iris",
>>>>> +		.data = &sm8550_data,
>>>>> +	},
>>>>> +	{
>>>>> +		.compatible = "qcom,sm8250-venus",
>>>>> +		.data = &sm8250_data,
>>>>
>>>> You just added this. No, please do not add code which is immediatly
>>>> incorrect.
>>> It's not incorrect, in earlier patch we only added the compatible strings
>>> and with this patch introducing the platform data and APIs to get it.
>>
>> It is incorrect to immediately remove it. You keep arguing on basic
>> stuff. Sorry, but that is not how it works. If you add code and
>> IMMEDIATELY remove it, then it means the code was not needed. Or was not
>> correct. Choose one.
> I think it is not removing it. It is adding platform data to compatibles
> introduced in previous patch. Maybe it appears as if it is removing it.

I know how the diff works.

The way you avoid solving the problem with trivial responses is not
helping. We already have been there with another patchset from different
person and it lead to annoying all DT maintainers and (usually very
patient) some of networking folks. I ask you to approach to the review
seriously.

NAK.

Best regards,
Krzysztof