lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <D3Z8S9922SIU.QD22EOW9RGT0@kernel.org> Date: Fri, 06 Sep 2024 16:40:06 +0300 From: "Jarkko Sakkinen" <jarkko@...nel.org> To: "Roberto Sassu" <roberto.sassu@...weicloud.com>, <corbet@....net>, <zohar@...ux.ibm.com>, <dmitry.kasatkin@...il.com>, <eric.snowberg@...cle.com>, <paul@...l-moore.com>, <jmorris@...ei.org>, <serge@...lyn.com> Cc: <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>, <linux-integrity@...r.kernel.org>, <linux-security-module@...r.kernel.org>, <wufan@...ux.microsoft.com>, <pbrobinson@...il.com>, <zbyszek@...waw.pl>, <hch@....de>, <mjg59@...f.ucam.org>, <pmatilai@...hat.com>, <jannh@...gle.com>, <dhowells@...hat.com>, <jikos@...nel.org>, <mkoutny@...e.com>, <ppavlu@...e.com>, <petr.vorel@...il.com>, <mzerqung@...inter.de>, <kgold@...ux.ibm.com>, "Roberto Sassu" <roberto.sassu@...wei.com> Subject: Re: [RFC][PATCH v3 01/10] ima: Introduce hook DIGEST_LIST_CHECK On Fri Sep 6, 2024 at 2:22 PM EEST, Roberto Sassu wrote: > On Fri, 2024-09-06 at 12:41 +0300, Jarkko Sakkinen wrote: > > On Thu Sep 5, 2024 at 6:25 PM EEST, Roberto Sassu wrote: > > > From: Roberto Sassu <roberto.sassu@...wei.com> > > > > > > Introduce a new hook to check the integrity of digest lists. > > > > "Introduce DIGEST_LIST_CHECK, a new hook..." > > > > > > > > The new hook is invoked during a kernel read with file type > > > > "with the file type" > > > > > > > READING_DIGEST LIST, which is done by the Integrity Digest Cache when it is > > > populating a digest cache with a digest list. > > > > The patch creates a new struct imap_rule_entry instance when it parses > > the corresponding rule, which means that there are couple slices of > > information missing here: > > > > 1. The commit message does not tell what the code change effectively > > is. I scavenged this information from [1]. > > Sorry, to me it seems a bit redundant to state what a IMA hook is. The > new hook will be handled by IMA like the other existing hooks. I think with documentation (scoping also to commit messages) it is in general a good strategy to put it less rather than more. No documentation is better than polluted documentation ;-) Just remarking what might not be obvious with someone who might not be obvious, unless being a pro-active contributor. BR, Jarkko
Powered by blists - more mailing lists