linux-kernel - Re: [PATCH 04/15] timers: Move *sleep*() and timeout functions into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtsGwgatGpFRQerw@pavilion.home>
Date: Fri, 6 Sep 2024 15:42:26 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc: Thomas Gleixner <tglx@...utronix.de>, Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH 04/15] timers: Move *sleep*() and timeout functions into
 a separate file

Le Wed, Sep 04, 2024 at 03:04:54PM +0200, Anna-Maria Behnsen a écrit :
> All schedule_timeout() and *sleep*() related functions are interfaces on
> top of timer list timers and hrtimers to add a sleep to the code. As they
> are built on top of the timer list timers and hrtimers, the [hr]timer
> interfaces are already used except when queuing the timer in
> schedule_timeout(). But there exists the appropriate interface add_timer()
> which does the same job with an extra check for an already pending timer.
> 
> Split all those functions as they are into a separate file and use
> add_timer() instead of __mod_timer() in schedule_timeout().
> 
> While at it fix minor formatting issues and a multi line printk function
> call in schedule_timeout(). While at it also add not listed
> include/linux/delay.h to the MAINTAINTERS file.

I don't mind sometimes having several logical changes within a same
patch if that makes sense but the delay is MAINTAINERS is pretty off-topic
and should move to its own patch.

> 
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>

For the rest:

Acked-by: Frederic Weisbecker <frederic@...nel.org>