linux-kernel - Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240907064656.bkefak6jqpwxffze@treble>
Date: Fri, 6 Sep 2024 23:46:56 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Song Liu <song@...nel.org>
Cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>,
	Joe Lawrence <joe.lawrence@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Marcos Paulo de Souza <mpdesouza@...e.com>
Subject: Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

On Tue, Sep 03, 2024 at 10:32:00AM -0700, Song Liu wrote:
> +++ w/tools/objtool/elf.c
> @@ -468,10 +468,8 @@ static void elf_add_symbol(struct elf *elf,
> struct symbol *sym)
>          *
>          * TODO: is this still true?
>          */
> -#if 0
> -       if (sym->type == STT_NOTYPE && !sym->len)
> +       if (sym->type == STT_NOTYPE && !sym->len && false)
>                 __sym_remove(sym, &sym->sec->symbol_tree);
> -#endif

Song, can you explain this change?  Was there a warning about
__sym_remove() not being used?  Not sure how that would be possible
since it should be static inline:

INTERVAL_TREE_DEFINE(struct symbol, node, unsigned long, __subtree_last,
		     __sym_start, __sym_last, static inline, __sym)
					      ^^^^^^^^^^^^^

-- 
Josh