linux-kernel - Re: [PATCH] smp: Mark smp_prepare_boot_cpu() _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H4miZqRDWw5SkfdJJRxuV_4obnqLWHc6zdgGC09xE5rRw@mail.gmail.com>
Date: Sat, 7 Sep 2024 16:33:07 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Bibo Mao <maobibo@...ngson.cn>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Michael Ellerman <mpe@...erman.id.au>, 
	Nicholas Piggin <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>, 
	Thomas Gleixner <tglx@...utronix.de>, Naveen N Rao <naveen@...nel.org>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] smp: Mark smp_prepare_boot_cpu() __init

Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn>

On Sat, Sep 7, 2024 at 4:27 PM Bibo Mao <maobibo@...ngson.cn> wrote:
>
> Function smp_prepare_boot_cpu() is only called at boot stage, here
> mark it as __init.
>
> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
> ---
>  arch/loongarch/kernel/smp.c | 2 +-
>  arch/mips/kernel/smp.c      | 2 +-
>  arch/powerpc/kernel/smp.c   | 2 +-
>  include/linux/smp.h         | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/loongarch/kernel/smp.c b/arch/loongarch/kernel/smp.c
> index ca405ab86aae..be2655c4c414 100644
> --- a/arch/loongarch/kernel/smp.c
> +++ b/arch/loongarch/kernel/smp.c
> @@ -476,7 +476,7 @@ core_initcall(ipi_pm_init);
>  #endif
>
>  /* Preload SMP state for boot cpu */
> -void smp_prepare_boot_cpu(void)
> +void __init smp_prepare_boot_cpu(void)
>  {
>         unsigned int cpu, node, rr_node;
>
> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 0362fc5df7b0..39e193cad2b9 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -439,7 +439,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
>  }
>
>  /* preload SMP state for boot cpu */
> -void smp_prepare_boot_cpu(void)
> +void __init smp_prepare_boot_cpu(void)
>  {
>         if (mp_ops->prepare_boot_cpu)
>                 mp_ops->prepare_boot_cpu();
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 46e6d2cd7a2d..4ab9b8cee77a 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -1166,7 +1166,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
>         cpu_smt_set_num_threads(num_threads, threads_per_core);
>  }
>
> -void smp_prepare_boot_cpu(void)
> +void __init smp_prepare_boot_cpu(void)
>  {
>         BUG_ON(smp_processor_id() != boot_cpuid);
>  #ifdef CONFIG_PPC64
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index fcd61dfe2af3..6a0813c905d0 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -109,7 +109,7 @@ static inline void on_each_cpu_cond(smp_cond_func_t cond_func,
>   * Architecture specific boot CPU setup.  Defined as empty weak function in
>   * init/main.c. Architectures can override it.
>   */
> -void smp_prepare_boot_cpu(void);
> +void __init smp_prepare_boot_cpu(void);
>
>  #ifdef CONFIG_SMP
>
>
> base-commit: b31c4492884252a8360f312a0ac2049349ddf603
> --
> 2.39.3
>