linux-kernel - Re: [PATCH v3 05/29] media: iris: implement iris v4l2 file ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1df7c433-5e25-4bd8-b8fe-547d66984832@web.de>
Date: Sat, 7 Sep 2024 10:52:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Vikash Garodia <quic_vgarodia@...cinc.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 05/29] media: iris: implement iris v4l2 file ops

…
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1.h
> @@ -0,0 +1,13 @@
…
> +#ifndef _IRIS_HFI_GEN1_H_
> +#define _IRIS_HFI_GEN1_H_
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus