linux-kernel - Re: [PATCH v3] dt-bindings: pinctrl: Add SA8255p TLMM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <q4d53nru2xy4drvyw27rsprsqgbneuj5zg35hmgyvvwoqmqbmg@pf5ojcmlmjwk>
Date: Sat, 7 Sep 2024 11:29:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: andersson@...nel.org, linus.walleij@...aro.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org, 
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel@...cinc.com, quic_psodagud@...cinc.com
Subject: Re: [PATCH v3] dt-bindings: pinctrl: Add SA8255p TLMM

On Thu, Sep 05, 2024 at 01:02:18PM -0700, Nikunj Kela wrote:
> Add compatible for TLMM block representing support on SA8255p.
> 
> SA8255p uses the same TLMM block as SA8775p however the ownership
> of pins are split between Firmware VM and Linux VM on SA8255p. For
> example, pins used by UART are owned and configured by Firmware VM
> while pins used by ethernet are owned and configured by Linux VM.
> Therefore, adding a sa8255p specific compatible to mark the difference.
> 
> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
> ---
> 
> Changes in v3:
> 	- Removed the patch from original series[1]
> 	- Fixed mising spaces schema errors
> 
> Changes in v2:
> 	- Modified subject line
> 	- Fixed schema to include fallback
> 
> [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/
> ---
>  .../devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml    | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> index e9abbf2c0689..749dbc563ac5 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> @@ -17,7 +17,13 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: qcom,sa8775p-tlmm
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,sa8255p-tlmm
> +          - const: qcom,sa8775p-tlmm
> +      - items:

No need to add items here, there were not present before. Anyway,

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof