linux-kernel - Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vtdrxh57zxpu6xktzehcpx7hkaqclg5kya5jojrbkmo76yswxx@libmc5evobkb>
Date: Sat, 7 Sep 2024 12:56:57 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Rudraksha Gupta <guptarud@...il.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
	regressions@...ts.linux.dev, brgl@...ev.pl, andersson@...nel.org, konrad.dybcio@...aro.org, 
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, robimarko@...il.com, 
	quic_gurus@...cinc.com, luzmaximilian@...il.com, catalin.marinas@....com, 
	will@...nel.org, srinivas.kandagatla@...aro.org, arnd@...db.de, 
	quic_eberman@...cinc.com, elder@...nel.org, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, kernel@...cinc.com, ahalaney@...hat.com, quic_djaggi@...cinc.com
Subject: Re: [REGRESSION] firmware: qcom: scm: smc: switch to using the SCM
 allocator

On Sat, Sep 07, 2024 at 01:49:02AM GMT, Rudraksha Gupta wrote:
> > Looks like qcom_scm_get_tzmem_pool() returns NULL. Not sure how this
> > happens. Can you confirm that the QCom SCM driver probed correctly?
> 
> Thanks for looking into this! Please let me know how I can help!
> 
> 
> I've been building the driver into the kernel I believe. Here's the relevant
> line in the config:
> 
> $ rg -i "scm"
> samsung/expressatt/linux.defconfig
> 1615:# CONFIG_ARM_SCMI_PROTOCOL is not set
> 1627:CONFIG_QCOM_SCM=y
> 1628:# CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT is not set
> 
> 
> It seems like the scm driver is being probed:
> 
> ~ # dmesg | grep scm
> [    0.066438] qcom_scm: convention: smc legacy
> [    0.362543] bus: 'platform': add driver qcom_scm

The scm driver is added, but it is not probed as there is no SCM node in
DT. I'll send and RFT patch to add it. However the issue still persists:
the driver should not crash if there is no SCM device on a system.
qcom_scm_*_alloc should fall back if there is no SCM.

> 
> 
> Also here is the complete dmesg output (Had to paste in pastebin as it made
> the email bigger than 100 KB):
> 
> https://pastebin.com/4iWKvZ8z

-- 
With best wishes
Dmitry