| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <43918eda-c4e8-471a-9de4-ea72bb090803@classfun.cn> Date: Sat, 7 Sep 2024 22:33:55 +0800 From: Junhao Xie <bigfoot@...ssfun.cn> To: Markus Elfring <Markus.Elfring@....de>, devicetree@...r.kernel.org, linux-hwmon@...r.kernel.org, linux-leds@...r.kernel.org, linux-pm@...r.kernel.org, linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org Cc: LKML <linux-kernel@...r.kernel.org>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Chukun Pan <amadeus@....edu.cn>, Conor Dooley <conor+dt@...nel.org>, Günter Röck <linux@...ck-us.net>, Heiko Stübner <heiko@...ech.de>, Jean Delvare <jdelvare@...e.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Lee Jones <lee@...nel.org>, Pavel Machek <pavel@....cz>, Rob Herring <robh@...nel.org>, Sebastian Reichel <sre@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org> Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU On 2024/9/7 16:44, Markus Elfring wrote: > … >> +++ b/include/linux/mfd/photonicat-pmu.h >> @@ -0,0 +1,86 @@ > … >> +#ifndef _PHOTONICAT_PMU_H >> +#define _PHOTONICAT_PMU_H > … > > I suggest to omit leading underscores from such identifiers. > https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier > > Regards, > Markus Thanks for your suggestion, does this look better? #ifndef MFD_PHOTONICAT_PMU_H #define MFD_PHOTONICAT_PMU_H Best regards, Junhao
Powered by blists - more mailing lists