linux-kernel - Re: [PATCH] cpufreq: mediatek-hw: Fix resource management and error handling in mtk_cpu_resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ab8c121-3fef-4d4d-a7b1-7892fb54b680@web.de>
Date: Sat, 7 Sep 2024 18:10:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Riyan Dhiman <riyandhiman14@...il.com>, linux-pm@...r.kernel.org,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: mediatek-hw: Fix resource management and error
 handling in mtk_cpu_resources_init()

>>> Memory region and IO memory were not released if mtk_cpu_create_freq_table() failed.
>>> Added error handling to ensure that IO memory is unmapped and the memory region is
>>> released properly to prevent resource leaks and ensure all resources are cleaned up on error.
>>
>> * Would you like to improve such a change description another bit
>
> Should I elaborate a little more on the issue and explain the fix I have created?

Please take another look at guidance from linked information sources.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n94

>>  also according to other line length preferences?
>
> Can you please help me a little bit about this?

Yes, of course.

> Is it the character lenght of subject?

Not directly.

The summary phrase can eventually become more succinct.

>> * How do you think about to add any tags (like "Fixes" and "Cc") accordingly?
>
> Should I change "patch" in subject to "Fixes" or …

Obviously not.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n145

Regards,
Markus