linux-kernel - Re: [PATCH next V2] PCI: brmstb: Fix type mismatch for num_inbound_wins in brcm_pcie_get_inbound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240907165611.GA238693@rocinante>
Date: Sun, 8 Sep 2024 01:56:11 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Riyan Dhiman <riyandhiman14@...il.com>
Cc: jim2101024@...il.com, nsaenz@...nel.org, florian.fainelli@...adcom.com,
	bcm-kernel-feedback-list@...adcom.com, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next V2] PCI: brmstb: Fix type mismatch for
 num_inbound_wins in brcm_pcie_get_inbound_wins

Hello,

> > Change num_inbound_wins from u8 to int to correctly handle
> > potential negative error codes returned by brcm_pcie_get_inbound_wins().
> > The u8 type was inappropriate for capturing the function's return value,
> > which can include error codes.
> 
> I squashed with the current code on the controller/brcmstb branch, see:
> 
>   - https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/brcmstb&id=ae6476c6de187bea90c729e3e0188143300fa671
> 
> And credited you via the Co-developed-by tag such that you get credit for
> fixing this issue.  Thank you, by the way.
> 
> There is no Fixes: tag as this code is not yet merged into the mainline.

For the record, I would prefer if we went with Florian's first
recommendation per the following message:

  - https://lore.kernel.org/linux-pci/159c5fcf-709d-42ba-8d45-a70b109fe261@broadcom.com

To clearly separate errors returned from the value being updated.

Albeit, this is fine too, especially as Jim expressed no opinion either
way regarding his preference.

	Krzysztof