linux-kernel - Re: [PATCH v1 1/1] iio: light: cm32181: Remove duplicate ACPI handle check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240907181750.78b27e6f@jic23-huawei>
Date: Sat, 7 Sep 2024 18:17:50 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Kevin Tsai
 <ktsai@...ellamicro.com>, Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/1] iio: light: cm32181: Remove duplicate ACPI
 handle check

On Wed,  4 Sep 2024 21:36:46 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> cm32181_acpi_parse_cpm_tables() is a no-op if ACPI handle
> is not available. Remove duplicate ACPI handle check at
> the caller side.
> 
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
Hmmm. Not the most obvious code give it relies on an error
being definitely less than the header size, but indeed it
will error out if the handle isn't there.

Applied.

Jonathan

> ---
>  drivers/iio/light/cm32181.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index 9df85b3999fa..aeae0566ec12 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -217,8 +217,7 @@ static int cm32181_reg_init(struct cm32181_chip *cm32181)
>  	cm32181->lux_per_bit = CM32181_LUX_PER_BIT;
>  	cm32181->lux_per_bit_base_it = CM32181_LUX_PER_BIT_BASE_IT;
>  
> -	if (ACPI_HANDLE(cm32181->dev))
> -		cm32181_acpi_parse_cpm_tables(cm32181);
> +	cm32181_acpi_parse_cpm_tables(cm32181);
>  
>  	/* Initialize registers*/
>  	for_each_set_bit(i, &cm32181->init_regs_bitmap, CM32181_CONF_REG_NUM) {