linux-kernel - Re: [PATCH v4 1/3] i2c: emev2: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtyrRLojI8GNiEj0@shikoro>
Date: Sat, 7 Sep 2024 21:36:36 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Rong Qianfeng <rongqianfeng@...o.com>
Cc: andriy.shevchenko@...el.com, biju.das.jz@...renesas.com,
	Andi Shyti <andi.shyti@...nel.org>,
	Paul Cercueil <paul@...pouillou.net>,
	linux-renesas-soc@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH v4 1/3] i2c: emev2: Use devm_clk_get_enabled() helpers

On Tue, Aug 27, 2024 at 11:48:39AM +0800, Rong Qianfeng wrote:
> The devm_clk_get_enabled() helpers:
>     - call devm_clk_get()
>     - call clk_prepare_enable() and register what is needed in order to
>      call clk_disable_unprepare() when needed, as a managed resource.
> 
> This simplifies the code and avoids the calls to clk_disable_unprepare().
> 
> While at it, no need to save clk pointer, drop sclk from struct
> em_i2c_device.
> 
> Signed-off-by: Rong Qianfeng <rongqianfeng@...o.com>

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)