linux-kernel - Re: [PATCHv4 net-next 0/8] net: ibm: emac: modernize a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKxU2N_ddO9Ts+4NeMOTA0h8-cU0g75t6gVZOq6UOp99M8_kcA@mail.gmail.com>
Date: Sat, 7 Sep 2024 13:02:51 -0700
From: Rosen Penev <rosenp@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: netdev@...r.kernel.org, andrew@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	linux-kernel@...r.kernel.org, jacob.e.keller@...el.com, horms@...nel.org, 
	sd@...asysnail.net, chunkeey@...il.com
Subject: Re: [PATCHv4 net-next 0/8] net: ibm: emac: modernize a bit

On Sat, Sep 7, 2024 at 12:43 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Le 07/09/2024 à 20:45, Rosen Penev a écrit :
> > It's a very old driver with a lot of potential for cleaning up code to
> > modern standards. This was a simple one dealing with mostly the probe
> > function and adding some devm to it.
> >
> > v2: removed the waiting code in favor of EPROBE_DEFER.
> > v3: reverse xmas order fix, unnecessary assignment fix, wrong usage of
> > EPROBE_DEFER fix.
> > v4: fixed line length warnings and unused goto.
> >
> > Rosen Penev (8):
> >    net: ibm: emac: manage emac_irq with devm
> >    net: ibm: emac: use devm for of_iomap
> >    net: ibm: emac: remove mii_bus with devm
> >    net: ibm: emac: use devm for register_netdev
> >    net: ibm: emac: use netdev's phydev directly
> >    net: ibm: emac: replace of_get_property
> >    net: ibm: emac: remove all waiting code
> >    net: ibm: emac: get rid of wol_irq
> >
> >   drivers/net/ethernet/ibm/emac/core.c | 210 +++++++++------------------
> >   drivers/net/ethernet/ibm/emac/core.h |   4 -
> >   2 files changed, 68 insertions(+), 146 deletions(-)
> >
> There was 9 patches in v3.
>
> Patch 1/9: net: ibm: emac: use devm for alloc_etherdev is no more.
> Is it removed intentionaly?
Nope. I messed up when resending.
>
> Also I made a comment on v3 6/9. It also apply to v4 5/9.
Sure. Unfortunately net-next closes on Monday. It might make sense to
resubmit when it reopens.
>
> CJ