linux-kernel - Re: [PATCH v4 1/3] dt-bindings: iio: adc: add AD762x/AD796x ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240908125328.004d6ff3@jic23-huawei>
Date: Sun, 8 Sep 2024 12:53:28 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Trevor Gamblin <tgamblin@...libre.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Nuno Sá <nuno.sa@...log.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>, David
 Lechner <dlechner@...libre.com>, Uwe Kleine-Konig
 <u.kleine-koenig@...libre.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: iio: adc: add AD762x/AD796x ADCs

On Wed, 04 Sep 2024 15:14:18 -0400
Trevor Gamblin <tgamblin@...libre.com> wrote:

> Add a binding specification for the Analog Devices Inc. AD7625,
> AD7626, AD7960, and AD7961 ADCs.
> 
> Signed-off-by: Trevor Gamblin <tgamblin@...libre.com>

Just one minor thing inline. I think the description of the gpios
is currently 'backwards'.

> +
> +  en0-gpios:
> +    description:
> +      Configurable EN0 pin.

Normally when we say a pin is configurable we mean the driver gets
to change what it means. Here there is no bus over which to configure it.
So this is a way of configuring what the device is doing.
EN0 pin used to configure XYZ..