linux-kernel - Re: [syzbot] [bluetooth?] KASAN: slab-use-after-free Read in l2cap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_891763176DE6D7D3632361C96023BBE44F05@qq.com>
Date: Sun,  8 Sep 2024 10:41:05 +0800
From: Edward Adam Davis <eadavis@...com>
To: syzbot+c12e2f941af1feb5632c@...kaller.appspotmail.com
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [bluetooth?] KASAN: slab-use-after-free Read in l2cap_connect (2)

after release conn, we need to cancle rx_work

#syz test

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index e79cd40bd079..6d95e07d9ddd 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -5499,7 +5499,7 @@ static int hci_reject_conn_sync(struct hci_dev *hdev, struct hci_conn *conn,
 
 int hci_abort_conn_sync(struct hci_dev *hdev, struct hci_conn *conn, u8 reason)
 {
-	int err = 0;
+	int err = 0, failed = 0;
 	u16 handle = conn->handle;
 	bool disconnect = false;
 	struct hci_conn *c;
@@ -5543,10 +5543,13 @@ int hci_abort_conn_sync(struct hci_dev *hdev, struct hci_conn *conn, u8 reason)
 		hci_conn_del(conn);
 	} else {
 		hci_conn_failed(conn, reason);
+		failed = 1;
 	}
 
 unlock:
 	hci_dev_unlock(hdev);
+	if (failed)
+		cancel_work_sync(&hdev->rx_work);
 	return err;
 }