linux-kernel - Re: [PATCH] ASoC: codecs: fix the right check and simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <066bcaba-8f3c-4afc-82ab-2c81ca4ceb95@web.de>
Date: Sun, 8 Sep 2024 16:36:07 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Tang Bin <tangbin@...s.chinamobile.com>, linux-sound@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Jaroslav Kysela <perex@...ex.cz>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Takashi Iwai <tiwai@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: codecs: fix the right check and simplify code

> In the file drivers/base/platform.c, the return description of
> platform_get_irq is 'non-zero IRQ number on success, negative
> error number on failure.', so the check is wrong, fix it. And
> when get irq failed, the function platform_get_irq logs an error
> message.

1. You may occasionally put more than 64 characters into text lines
   of such a change description.

2. How do you think about to split any changes into separate update steps?
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n81

3. I find the wording “fix the right check” confusing.


Regards,
Markus