linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: imu: add bmi270 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2jvzk37rx3lx47j4p5sjl4xgzcsinog5mc5ew2nseos2fuqnhm@mj7wzzgwtdpq>
Date: Sun, 8 Sep 2024 14:21:17 -0400
From: Alex Lanzano <lanzano.alex@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Ramona Gradinariu <ramona.bolboaca13@...il.com>, Nuno Sa <nuno.sa@...log.com>, 
	Jagath Jog J <jagathjog1996@...il.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: add bmi270 bindings

On Sat, Sep 07, 2024 at 04:47:43PM GMT, Jonathan Cameron wrote:
> On Fri,  6 Sep 2024 12:52:50 -0400
> Alex Lanzano <lanzano.alex@...il.com> wrote:
> 
> > Add device tree bindings for the bmi270 IMU
> > 
> > Signed-off-by: Alex Lanzano <lanzano.alex@...il.com>
> Hi Alex 
> 
> One totally trivial thing inline. If nothing comes up in
> driver I'll tidy this up whilst applying
> 
> Jonathan
> 

Will apply in v3!

> > ---
> >  .../bindings/iio/imu/bosch,bmi270.yaml        | 77 +++++++++++++++++++
> >  1 file changed, 77 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml
> > new file mode 100644
> > index 000000000000..7de35b9bfa2e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml
> > @@ -0,0 +1,77 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/imu/bosch,bmi270.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Bosch BMI270 6-Axis IMU
> > +
> > +maintainers:
> > +  - Alex Lanzano <lanzano.alex@...il.com>
> > +
> > +description: |
> > +  BMI270 is a 6-axis inertial measurement unit that can measure acceleration and
> > +  angular velocity. The sensor also supports configurable interrupt events such
> > +  as motion, step counter, and wrist motion gestures. The sensor can communicate
> > +  I2C or SPI.
> > +  https://www.bosch-sensortec.com/products/motion-sensors/imus/bmi270/
> > +
> > +properties:
> > +  compatible:
> > +    const: bosch,bmi270
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vdd-supply: true
> > +  vddio-supply: true
> > +
> > +  interrupts:
> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  interrupt-names:
> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      enum:
> > +        - INT1
> > +        - INT2
> > +
> > +  drive-open-drain:
> > +    description:
> > +      set if the specified interrupt pin should be configured as
> 
> pins
> 
> Even if they are configurable separately we've previously argued that
> it is very unlikely a board designer would want one open drain
> and the other push-pull.  So simply making the description plural
> should be enough.
> 

Will Fix in v3!

> > +      open drain. If not set, defaults to push-pull.
> > +
> > +  mount-matrix:
> > +    description:
> > +      an optional 3x3 mounting rotation matrix.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - vdd-supply
> > +  - vddio-supply
> > +
> > +allOf:
> > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        imu@68 {
> > +            compatible = "bosch,bmi270";
> > +            reg = <0x68>;
> > +            vdd-supply = <&vdd>;
> > +            vddio-supply = <&vddio>;
> > +            interrupt-parent = <&gpio1>;
> > +            interrupts = <16 IRQ_TYPE_EDGE_RISING>;
> > +            interrupt-names = "INT1";
> > +        };
> > +    };

Thanks so much for the review!

Best regards,
Alex