linux-kernel - RE: [PATCH 5/9] vdso: Split linux/minmax.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79a350d94d754a16864b55336e50bce6@AcuMS.aculab.com>
Date: Sun, 8 Sep 2024 19:58:32 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Vincenzo Frascino' <vincenzo.frascino@....com>, Arnd Bergmann
	<arnd@...db.de>, Christophe Leroy <christophe.leroy@...roup.eu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Linux-Arch
	<linux-arch@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>
CC: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	"Jason A . Donenfeld" <Jason@...c4.com>, Michael Ellerman
	<mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Naveen N Rao
	<naveen@...nel.org>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
	<bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin"
	<hpa@...or.com>, Theodore Ts'o <tytso@....edu>, Andrew Morton
	<akpm@...ux-foundation.org>, Steven Rostedt <rostedt@...dmis.org>, "Masami
 Hiramatsu" <mhiramat@...nel.org>, Mathieu Desnoyers
	<mathieu.desnoyers@...icios.com>
Subject: RE: [PATCH 5/9] vdso: Split linux/minmax.h

From: Vincenzo Frascino
> Sent: 06 September 2024 12:41
> 
> On 04/09/2024 18:23, Arnd Bergmann wrote:
> > On Wed, Sep 4, 2024, at 17:17, Christophe Leroy wrote:
> >> Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit :
> >>> The VDSO implementation includes headers from outside of the
> >>> vdso/ namespace.
> >>>
> >>> Split linux/minmax.h to make sure that the generic library
> >>> uses only the allowed namespace.
> >>
> >> It is probably easier to just don't use min_t() in VDSO. Can be open
> >> coded without impeeding readability.
> >
> > Right, or possibly the even simpler MIN()/MAX() if the arguments
> > have no side-effects.
> >
> 
> Agreed, generally I do not like open-coding since it tends to introduce
> duplication, but these cases are simple especially if we can use MIN()/MAX().

Aren't MIN()/MAX() likely to get defined in minmax.h for cases where the
arguments are constants - and maybe have checks that they are constants.
So you don't want to define them in the VDSO header either.

Open coding simple cases is actually easier to read :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)