linux-kernel - Re: [PATCH 05/19] rust: enable `clippy::unnecessary_safety

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D40QCUK9BVHC.8W0E99JLSXX3@gmail.com>
Date: Sun, 08 Sep 2024 09:38:59 +0200
From: "Vincenzo Palazzo" <vincenzopalazzodev@...il.com>
To: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Wedson Almeida Filho" <wedsonaf@...il.com>
Cc: "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <benno.lossin@...ton.me>, "Andreas Hindborg" <a.hindborg@...sung.com>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <patches@...ts.linux.dev>
Subject: Re: [PATCH 05/19] rust: enable `clippy::unnecessary_safety_comment`
 lint

> In Rust 1.67.0, Clippy added the `unnecessary_safety_comment` lint [1],
> which is the "inverse" of `undocumented_unsafe_blocks`: it finds places
> where safe code has a `// SAFETY` comment attached.
>
> The lint currently finds 3 places where we had such mistakes, thus it
> seems already quite useful.
>
> Thus clean those and enable it.
>
> Link: https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_safety_comment [1]
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> ---

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@...il.com>