linux-kernel - Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <917ac8d8-a483-422c-a408-cdd44793e910@kernel.org>
Date: Sun, 8 Sep 2024 10:14:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Junhao Xie <bigfoot@...ssfun.cn>, devicetree@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-leds@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-rtc@...r.kernel.org,
 linux-watchdog@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Chukun Pan <amadeus@....edu.cn>, Conor Dooley <conor+dt@...nel.org>,
 Günter Röck <linux@...ck-us.net>,
 Heiko Stübner <heiko@...ech.de>,
 Jean Delvare <jdelvare@...e.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Lee Jones <lee@...nel.org>, Pavel Machek <pavel@....cz>,
 Rob Herring <robh@...nel.org>, Sebastian Reichel <sre@...nel.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>
Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU

On 07/09/2024 16:33, Junhao Xie wrote:
> On 2024/9/7 16:44, Markus Elfring wrote:
>> …
>>> +++ b/include/linux/mfd/photonicat-pmu.h
>>> @@ -0,0 +1,86 @@
>> …
>>> +#ifndef _PHOTONICAT_PMU_H
>>> +#define _PHOTONICAT_PMU_H
>> …
>>
>> I suggest to omit leading underscores from such identifiers.
>> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
>>
>> Regards,
>> Markus
> 
> Thanks for your suggestion, does this look better?
> #ifndef MFD_PHOTONICAT_PMU_H
> #define MFD_PHOTONICAT_PMU_H

<form letter>
Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
several maintainers ignore Markus' feedback, because it is just a waste
of time.
</form letter>

Best regards,
Krzysztof