linux-kernel - Re: [PATCH wireless-next v2 2/3] wifi: wlcore: sdio: Make use of irq_get_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a7f5870-b74e-4c0e-8d76-b97b45bae963@ti.com>
Date: Mon, 9 Sep 2024 13:36:19 +0400
From: "Khan, Sabeeh" <sabeeh-khan@...com>
To: Vasileios Amoiridis <vassilisamir@...il.com>,
        <arend.vanspriel@...adcom.com>, <kvalo@...nel.org>
CC: <knaerzche@...il.com>, <leitao@...ian.org>, <linus.walleij@...aro.org>,
        <javierm@...hat.com>, <linux-wireless@...r.kernel.org>,
        <brcm80211@...ts.linux.dev>, <brcm80211-dev-list.pdl@...adcom.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wireless-next v2 2/3] wifi: wlcore: sdio: Make use of
 irq_get_trigger_type()

Hi Vasileios,

On 9/4/2024 7:49 PM, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> ---
>  drivers/net/wireless/ti/wlcore/sdio.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
> index 92fb5b8dcdae..9e1b644beba9 100644
> --- a/drivers/net/wireless/ti/wlcore/sdio.c
> +++ b/drivers/net/wireless/ti/wlcore/sdio.c
> @@ -324,15 +324,13 @@ static int wl1271_probe(struct sdio_func *func,
>  	memset(res, 0x00, sizeof(res));
>  
>  	res[0].start = irq;
> -	res[0].flags = IORESOURCE_IRQ |
> -		       irqd_get_trigger_type(irq_get_irq_data(irq));
> +	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
>  	res[0].name = "irq";
>  
>  
>  	if (wakeirq > 0) {
>  		res[1].start = wakeirq;
> -		res[1].flags = IORESOURCE_IRQ |
> -			       irqd_get_trigger_type(irq_get_irq_data(wakeirq));
> +		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
>  		res[1].name = "wakeirq";
>  		num_irqs = 2;
>  	} else {
Reviewed-by: Sabeeh Khan <sabeeh-khan@...com>
Tested-by: Sabeeh Khan <sabeeh-khan@...com>