linux-kernel - Re: [PATCH net v2] net: dpaa: Pad packets to ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJoA5XNOGr6-esswau8VymFHrrpT62+CT=nf4KLuDU-Ag@mail.gmail.com>
Date: Tue, 10 Sep 2024 16:46:09 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Madalin Bucur <madalin.bucur@....com>, netdev@...r.kernel.org, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org, 
	"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net v2] net: dpaa: Pad packets to ETH_ZLEN

On Tue, Sep 10, 2024 at 4:32 PM Sean Anderson <sean.anderson@...ux.dev> wrote:
>
> When sending packets under 60 bytes, up to three bytes of the buffer
> following the data may be leaked. Avoid this by extending all packets to
> ETH_ZLEN, ensuring nothing is leaked in the padding. This bug can be
> reproduced by running
>
>         $ ping -s 11 destination
>
> Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !