linux-kernel - Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae4db880-d64c-446b-bbf8-954b7bebca83@collabora.com>
Date: Tue, 10 Sep 2024 18:52:35 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Markus Elfring <Markus.Elfring@....de>,
 Algea Cao <algea.cao@...k-chips.com>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, kernel@...labora.com,
 Andrzej Hajda <andrzej.hajda@...el.com>, Andy Yan <andy.yan@...k-chips.com>,
 Conor Dooley <conor+dt@...nel.org>, Daniel Vetter <daniel@...ll.ch>,
 David Airlie <airlied@...il.com>, Heiko Stübner
 <heiko@...ech.de>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Jonas Karlman <jonas@...boo.se>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Mark Yao <markyao0591@...il.com>, Maxime Ripard <mripard@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>, Rob Herring <robh@...nel.org>,
 Robert Foss <rfoss@...nel.org>, Sandy Huang <hjc@...k-chips.com>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Thomas Zimmermann <tzimmermann@...e.de>
Cc: LKML <linux-kernel@...r.kernel.org>, Alexandre Arnoud <aarnoud@...com>,
 Luis de Arquer <ldearquer@...il.com>
Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller
 support library

On 9/8/24 12:11 PM, Markus Elfring wrote:
> …
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
>> @@ -0,0 +1,708 @@
> …
>> +static int dw_hdmi_qp_i2c_xfer(struct i2c_adapter *adap,
>> +			       struct i2c_msg *msgs, int num)
>> +{
> …
>> +	mutex_lock(&i2c->lock);
> …
>> +	dw_hdmi_qp_mod(hdmi, 0, I2CM_OP_DONE_MASK_N | I2CM_NACK_RCVD_MASK_N,
>> +		       MAINUNIT_1_INT_MASK_N);
>> +
>> +	mutex_unlock(&i2c->lock);
>> +
>> +	return ret;
>> +}
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&i2c->lock);”?
> https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/mutex.h#L196

Applied for the upcoming v7.

Thanks,
Cristian