linux-kernel - Re: [PATCH v1 00/15] Tool and hwmon PMUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f89d1f85-9ae9-43c9-ab2a-24614cbae1ac@roeck-us.net>
Date: Mon, 9 Sep 2024 20:36:09 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Kan Liang <kan.liang@...ux.intel.com>, John Garry <john.g.garry@...cle.com>,
 Will Deacon <will@...nel.org>, James Clark <james.clark@...aro.org>,
 Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
 Ravi Bangoria <ravi.bangoria@....com>, Weilin Wang <weilin.wang@...el.com>,
 Jing Zhang <renyu.zj@...ux.alibaba.com>, Xu Yang <xu.yang_2@....com>,
 Sandipan Das <sandipan.das@....com>, Benjamin Gray <bgray@...ux.ibm.com>,
 Athira Jajeev <atrajeev@...ux.vnet.ibm.com>,
 Howard Chu <howardchu95@...il.com>,
 Dominique Martinet <asmadeus@...ewreck.org>,
 Yang Jihong <yangjihong@...edance.com>,
 Colin Ian King <colin.i.king@...il.com>,
 Veronika Molnarova <vmolnaro@...hat.com>,
 "Dr. David Alan Gilbert" <linux@...blig.org>,
 Oliver Upton <oliver.upton@...ux.dev>, Changbin Du <changbin.du@...wei.com>,
 Ze Gao <zegao2021@...il.com>, Andi Kleen <ak@...ux.intel.com>,
 Clément Le Goffic <clement.legoffic@...s.st.com>,
 Sun Haiyong <sunhaiyong@...ngson.cn>, Junhao He <hejunhao3@...wei.com>,
 Tiezhu Yang <yangtiezhu@...ngson.cn>, Yicong Yang
 <yangyicong@...ilicon.com>, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v1 00/15] Tool and hwmon PMUs

On 9/9/24 19:21, Ian Rogers wrote:
> On Fri, Sep 6, 2024 at 10:08 PM Ian Rogers <irogers@...gle.com> wrote:
>>
>> Rather than have fake and tool PMUs being special flags in an evsel,
>> create special PMUs. This allows, for example, duration_time to also
>> be tool/duration_time/. Once adding events to the tools PMU is just
>> adding to an array, add events for nearly all the expr literals like
>> num_cpus_online. Rather than create custom logic for finding and
>> describing the tool events use json and add a notion of common json
>> for the tool events.
>>
>> Following the convention of the tool PMU, create a hwmon PMU that
>> exposes hwmon data for reading. For example, the following shows
>> reading the CPU temperature and 2 fan speeds alongside the uncore
>> frequency:
>> ```
>> $ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000
>>       1.001153138              52.00 'C   temp_cpu
>>       1.001153138              2,588 rpm  fan1
>>       1.001153138              2,482 rpm  hwmon_thinkpad/fan2/
>>       1.001153138                  8      tool/num_cpus_online/
>>       1.001153138      1,077,101,397      UNC_CLOCK.SOCKET                 #     1.08 UNCORE_FREQ
>>       1.001153138      1,012,773,595      duration_time
>> ...
>> ```
> 
> +linux-hwmon@...r.kernel.org as a heads up.
> 

No idea what you are doing, or why. I am not sure if I care, unless you
introduce dependencies on hwmon internals (or, in other words, define
undocumented APIs into hwmon). Which I'd argue would be a no-go.

Guenter