linux-kernel - Re: [PATCH] block/blk-rq-qos: introduce macro RQ_QOS_FN for common behaviors in rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85a71ca6-3011-4bcf-bdb8-cb57e1be23ce@acm.org>
Date: Tue, 10 Sep 2024 09:56:12 -0700
From: Bart Van Assche <bvanassche@....org>
To: chensong_2000@....cn, axboe@...nel.dk
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block/blk-rq-qos: introduce macro RQ_QOS_FN for common
 behaviors in rq_qos*

On 9/10/24 1:42 AM, chensong_2000@....cn wrote:
> +#define RQ_QOS_FN(q, fn, ...)	\
> +	do {	\
> +		struct rq_qos *rqos;	\
> +		for_each_rqos(rqos, q)	\
> +			if (rqos->ops->fn)	\
> +				rqos->ops->fn(rqos, ##__VA_ARGS__);	\
> +	} while (0)

I'm not sure whether this patch is a step in the right direction. If
others agree with the approach of this patch, I think we need a better
name for this macro, e.g. CALL_RQ_QOS_FN().

Thanks,

Bart.