linux-kernel - Re: [PATCH v2] remoteproc: k3-dsp: Fix an error handling path in k3_dsp_rproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be4bcfa9-6445-4e8a-a510-0777341026b0@wanadoo.fr>
Date: Tue, 10 Sep 2024 18:56:07 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Mathieu Poirier <mathieu.poirier@...aro.org>,
 Julia Lawall <Julia.Lawall@...6.fr>
Cc: Bjorn Andersson <andersson@...nel.org>, Beleswar Padhi <b-padhi@...com>,
 Andrew Davis <afd@...com>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH v2] remoteproc: k3-dsp: Fix an error handling path in
 k3_dsp_rproc_probe()

Le 10/09/2024 à 17:29, Mathieu Poirier a écrit :

>> +static void k3_dsp_free_channel(void *data)
>> +{
>> +	struct k3_dsp_rproc *kproc = data;
> 
> How did the struct rproc from devm_add_action_or_reset() got turned into a
> struct k3_dsp_rproc?
> 

Well, Linux is a wonderful system, that is able to make wonderful thinks!

In this particular case, if it is not the correct explanation, it is 
likely an unfortunate typo :(
Sorry about that, and thanks for the careful review.
I'll send a v3.


But, looking at it, and trying to see if similar issues may exist, the 
following naive script spots 2 similar issues. 1 of them looks valid.


I'll try to improve it (Julia in copy, if she wants to give it a look 
as-well :))

CJ



@devm@
expression RET, DEV;
identifier FCT, VAR;
type T;
@@
	T VAR;
	...
(
	RET = devm_add_action_or_reset(DEV, FCT, VAR);
|
	devm_add_action_or_reset(DEV, FCT, VAR);
)

@depends on devm@
identifier FCT = devm.FCT, x, VAR;
type T1 = devm.T, T2;
@@
void FCT(void *x)
{
	...
(
	T1 VAR = x;
|
*	T2 VAR = x;
)
	...
}