linux-kernel - Re: [tip: perf/core] uprobes: switch to RCU Tasks Trace flavor for better performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZihPPiReE3anhrVOzjoZW5v4vFVouK_Arm8vJexCTT4g@mail.gmail.com>
Date: Tue, 10 Sep 2024 10:39:53 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: "Peter Zijlstra (Intel)" <peterz@...radead.org>, linux-tip-commits@...r.kernel.org, 
	Andrii Nakryiko <andrii@...nel.org>, Oleg Nesterov <oleg@...hat.com>, x86@...nel.org, 
	linux-kernel@...r.kernel.org, "Paul E . McKenney" <paulmck@...nel.org>, 
	bpf <bpf@...r.kernel.org>, Jiri Olsa <jolsa@...nel.org>
Subject: Re: [tip: perf/core] uprobes: switch to RCU Tasks Trace flavor for
 better performance

On Tue, Sep 10, 2024 at 3:37 AM Ingo Molnar <mingo@...nel.org> wrote:
>
>
> * Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:
>
> > On Thu, Sep 5, 2024 at 8:03 AM tip-bot2 for Andrii Nakryiko
> > <tip-bot2@...utronix.de> wrote:
> > >
> > > The following commit has been merged into the perf/core branch of tip:
> > >
> > > Commit-ID:     c4d4569c41f9cda745cfd1d8089ea3d3526bafe5
> > > Gitweb:        https://git.kernel.org/tip/c4d4569c41f9cda745cfd1d8089ea3d3526bafe5
> > > Author:        Andrii Nakryiko <andrii@...nel.org>
> > > AuthorDate:    Tue, 03 Sep 2024 10:46:03 -07:00
> > > Committer:     Peter Zijlstra <peterz@...radead.org>
> > > CommitterDate: Thu, 05 Sep 2024 16:56:15 +02:00
> > >
> >
> > Hm... This commit landed in perf/core, but is gone now (the rest of
> > patches is still there). Any idea what happened?
>
> Yeah, I'm getting this build failure:
>
>      kernel/events/uprobes.c:1158:9: error: implicit declaration of function ‘synchronize_rcu_tasks_trace’; did you mean ‘synchronize_rcu_tasks’? [-Werror=implicit-function-declaration]
>
> on x86-64 defconfig, when applied to today's perf/core.
>

I see, I need to add `select TASKS_TRACE_RCU` to UPROBES kconfig, I'll
fix it up and send this patch separately.

Next time please let me know ASAP about issues with my patches so I
can fix stuff like this quickly.

> Thanks,
>
>         Ingo