linux-kernel - Re: [PATCH] clk: ralink: mtmips: fix clock plan for Ralink SoC RT3883

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs-H9rJEO8Yje1qsWQ9rt19wLZLbbiVVa3aR_Uwh2QRO9a=Q@mail.gmail.com>
Date: Tue, 10 Sep 2024 06:14:54 +0200
From: Sergio Paracuellos <sergio.paracuellos@...il.com>
To: Shiji Yang <yangshiji66@...look.com>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	mturquette@...libre.com, sboyd@...nel.org, tsbogend@...ha.franken.de
Subject: Re: [PATCH] clk: ralink: mtmips: fix clock plan for Ralink SoC RT3883

Hi Shiji,

On Mon, Sep 9, 2024 at 1:20 PM Shiji Yang <yangshiji66@...look.com> wrote:
>
> On Tue,  6 Aug 2024 16:29:02 +0200, Sergio Paracuellos wrote:
>
> >diff --git a/drivers/clk/ralink/clk-mtmips.c b/drivers/clk/ralink/clk-mtmips.c
> >index 50a443bf79ec..787ff3e66b34 100644
> >--- a/drivers/clk/ralink/clk-mtmips.c
> >+++ b/drivers/clk/ralink/clk-mtmips.c
> >@@ -267,6 +267,11 @@ static struct mtmips_clk_fixed rt305x_fixed_clocks[] = {
> >       CLK_FIXED("xtal", NULL, 40000000)
> > };
> >
> >+static struct mtmips_clk_fixed rt3383_fixed_clocks[] = {
>
> Hi! I found a small issue. The SoC name is rt3883 instead of rt3383.

Ouch :). True. Since I have some other pending patches of this driver
I will fix this and
send a new patchset including this fixed.

Thanks,
    Sergio Paracuellos
>
> >+      CLK_FIXED("xtal", NULL, 40000000),
> >+      CLK_FIXED("periph", "xtal", 40000000)
> >+};
> >+
> > static struct mtmips_clk_fixed rt3352_fixed_clocks[] = {
> >       CLK_FIXED("periph", "xtal", 40000000)
> > };
> >@@ -779,8 +784,8 @@ static const struct mtmips_clk_data rt3352_clk_data = {
> > static const struct mtmips_clk_data rt3883_clk_data = {
> >       .clk_base = rt3883_clks_base,
> >       .num_clk_base = ARRAY_SIZE(rt3883_clks_base),
> >-      .clk_fixed = rt305x_fixed_clocks,
> >-      .num_clk_fixed = ARRAY_SIZE(rt305x_fixed_clocks),
> >+      .clk_fixed = rt3383_fixed_clocks,
> >+      .num_clk_fixed = ARRAY_SIZE(rt3383_fixed_clocks),
> >       .clk_factor = NULL,
> >       .num_clk_factor = 0,
> >       .clk_periph = rt5350_pherip_clks,
>
> Regards,
> Shiji Yang