linux-kernel - Re: [PATCH v1 1/1] PM: hibernate: Remove unused stub for saveable_highmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jkV4xcuKpLkGUzDc6PMfjBuS67hDr1MxMybus+d_cUrw@mail.gmail.com>
Date: Tue, 10 Sep 2024 20:17:02 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] PM: hibernate: Remove unused stub for saveable_highmem_page()

On Thu, Sep 5, 2024 at 8:48 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> When saveable_highmem_page() is unused, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:
>
> kernel/power/snapshot.c:1369:21: error: unused function 'saveable_highmem_page' [-Werror,-Wunused-function]
>  1369 | static inline void *saveable_highmem_page(struct zone *z, unsigned long p)
>       |                     ^~~~~~~~~~~~~~~~~~~~~
>
> Fix this by removing unused stub.
>
> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> inline functions for W=1 build").
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  kernel/power/snapshot.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 405eddbda4fc..30894d8f0a78 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -1365,11 +1365,6 @@ static unsigned int count_highmem_pages(void)
>         }
>         return n;
>  }
> -#else
> -static inline void *saveable_highmem_page(struct zone *z, unsigned long p)
> -{
> -       return NULL;
> -}
>  #endif /* CONFIG_HIGHMEM */
>
>  /**
> --

Applied as 6.12 material, thanks!