linux-kernel - Re: [PATCH v1 1/6] pmdomain: rockchip: forward rockchip_do_pmu_set_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4131747.ReJHH8Nr61@diego>
Date: Tue, 10 Sep 2024 20:21:34 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Elaine Zhang <zhangqing@...k-chips.com>,
 Adrián Martínez Larumbe <adrian.larumbe@...labora.com>,
 Boris Brezillon <boris.brezillon@...labora.com>, devicetree@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org,
 Sebastian Reichel <sebastian.reichel@...labora.com>, kernel@...labora.com
Subject:
 Re: [PATCH v1 1/6] pmdomain: rockchip: forward
 rockchip_do_pmu_set_power_domain errors

Am Dienstag, 10. September 2024, 19:57:10 CEST schrieb Sebastian Reichel:
> Currently rockchip_do_pmu_set_power_domain prints a warning if there
> have been errors turning on the power domain, but it does not return
> any errors and rockchip_pd_power() tries to continue setting up the
> QOS registers. This usually results in accessing unpowered registers,
> which triggers an SError and a full system hang.
> 
> This improves the error handling by forwarding the error to avoid
> kernel panics.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

more error handling is always better :-)

Reviewed-by: Heiko Stuebner <heiko@...ech.de>