linux-kernel - Re: [PATCH] ACPI: PM: Quirk ASUS ROG M16 to default to S3 sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ii=P6mW2DFz0wNw2_nRYEe=ts+T=_pZvnV9aLoMAp-DA@mail.gmail.com>
Date: Tue, 10 Sep 2024 20:21:10 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: "Luke D. Jones" <luke@...nes.dev>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, lenb@...nel.org, 
	rafael@...nel.org
Subject: Re: [PATCH] ACPI: PM: Quirk ASUS ROG M16 to default to S3 sleep

On Sun, Sep 8, 2024 at 7:36 AM Luke D. Jones <luke@...nes.dev> wrote:
>
> The 2023 ASUS ROG Zephyrus M16 can suffer from quite a variety of events
> causing wakeup from s2idle sleep. The events may come from the EC being
> noisey, from the MMC reader, from the AniMe matrix display on some models
> or from AC events.
>
> Defaulting to S3 sleep prevents all these wakeup issues.
>
> Signed-off-by: Luke D. Jones <luke@...nes.dev>
> ---
>  drivers/acpi/sleep.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 889f1c1a1fa9..c8ee8e42b0f6 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -351,6 +351,20 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
>                 DMI_MATCH(DMI_PRODUCT_NAME, "1025C"),
>                 },
>         },
> +       /*
> +        * The ASUS ROG M16 from 2023 has many events which wake it from s2idle
> +        * resulting in excessive battery drain and risk of laptop overheating,
> +        * these events can be caused by the MMC or  y AniMe display if installed.
> +        * The match is valid for all of the GU604V<x> range.
> +        */
> +       {
> +       .callback = init_default_s3,
> +       .ident = "ASUS ROG Zephyrus M16 (2023)",
> +       .matches = {
> +               DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +               DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus M16 GU604V"),
> +               },
> +       },
>         /*
>          * https://bugzilla.kernel.org/show_bug.cgi?id=189431
>          * Lenovo G50-45 is a platform later than 2012, but needs nvs memory
> --

Applied as 6.12 material, thanks!