linux-kernel - Re: [PATCH -next] PCI: altera: Replace TLP_REQ_ID() with macro PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240910191206.GB2136712@rocinante>
Date: Wed, 11 Sep 2024 04:12:06 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Jinjie Ruan <ruanjinjie@...wei.com>, joyce.ooi@...el.com,
	lpieralisi@...nel.org, manivannan.sadhasivam@...aro.org,
	robh@...nel.org, bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] PCI: altera: Replace TLP_REQ_ID() with macro
 PCI_DEVID()

Hello,

[...]
> >  #define TLP_READ_TAG			0x1d
> >  #define TLP_WRITE_TAG			0x10
> >  #define RP_DEVFN			0
> > -#define TLP_REQ_ID(bus, devfn)		(((bus) << 8) | (devfn))
> >  #define TLP_CFG_DW0(pcie, cfg)		\
> >  		(((cfg) << 24) |	\
> >  		  TLP_PAYLOAD_SIZE)
> >  #define TLP_CFG_DW1(pcie, tag, be)	\
> > -	(((TLP_REQ_ID(pcie->root_bus_nr,  RP_DEVFN)) << 16) | (tag << 8) | (be))
> > +	(((PCI_DEVID(pcie->root_bus_nr,  RP_DEVFN)) << 16) | (tag << 8) | (be))
> 
> This doesn't cause a problem per se, but PCI_DEVID() is defined
> basically as a PCI core convenience without any particular connection
> to the PCIe Requester ID format, so I don't think this is an
> improvement.

I will drop this patch based on feedback from Bjorn.

	Krzysztof