linux-kernel - Re: [PATCH 3/4] cgroup: Disallow mounting v1 hierarchies without controller implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuCmLXMLQd7xMs06@slm.duckdns.org>
Date: Tue, 10 Sep 2024 10:03:57 -1000
From: Tejun Heo <tj@...nel.org>
To: Michal Koutný <mkoutny@...e.com>
Cc: cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Zefan Li <lizefan.x@...edance.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...nel.org>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Shakeel Butt <shakeel.butt@...ux.dev>,
	Muchun Song <muchun.song@...ux.dev>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chen Ridong <chenridong@...wei.com>
Subject: Re: [PATCH 3/4] cgroup: Disallow mounting v1 hierarchies without
 controller implementation

On Mon, Sep 09, 2024 at 06:32:22PM +0200, Michal Koutný wrote:
> The configs that disable some v1 controllers would still allow mounting
> them but with no controller-specific files. (Making such hierarchies
> equivalent to named v1 hierarchies.) To achieve behavior consistent with
> actual out-compilation of a whole controller, the mounts should treat
> respective controllers as non-existent.
> 
> Wrap implementation into a helper function, leverage legacy_files to
> detect compiled out controllers. The effect is that mounts on v1 would
> fail and produce a message like:
>   [ 1543.999081] cgroup: Unknown subsys name 'memory'
> 
> Signed-off-by: Michal Koutný <mkoutny@...e.com>

Applied to cgroup/for-6.12.

Thanks.

-- 
tejun