linux-kernel - Re: [PATCH v3] lib: Export the parsing functions and related data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eced6aba-cef0-47d1-a200-3934dd483d94@intel.com>
Date: Tue, 10 Sep 2024 14:26:16 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Shawn.Shao <shawn.shao@...uarmicro.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] lib: Export the parsing functions and related data



On 9/9/2024 7:47 PM, Shawn.Shao wrote:
> From: Shawn Shao <shawn.shao@...uarmicro.com>
> 
> v1 -> v2: Updated the commit message, added a description
> 	of the changes related to `DeviceUpdateOptionFlags`, etc.
> v2 -> v3: separate the device_update_flags into another patch
> 

Minor nit, not worth a re-roll on its own, but the new title does not
mention pldmfw.

> The PLDM library is used to implement firmware upgrades,
> but the current library functions only support the
> `pldmfw_flash_image` function to complete a fixed
> process of parsing, sending data to the backend,
> and flashing (allowing users to implement custom
> logic using `pldmfw_ops`). However, this poses
> significant challenges for device vendors using
> PLDM for firmware upgrades.
> The following scenarios are not supported:
> 1. Only using the PLDM parsing functions, as the
>    current library does not support this operation.
> 2. The firmware upgrade process differs from this
>    fixed flow (the firmware upgrade process may
>    vary across different vendors).
> 	|-> pldmfw_flash_image
> 		|-> pldm_parse_image
> 			|-> pldm_parse_header
> 			|-> pldm_parse_records
> 			|-> pldm_parse_components
> 			-> pldm_verify_header_crc
> 		|-> pldm_find_matching_record (xxx_match_record)
> 		|-> pldm_send_package_data (xxx_send_package_data)
> 		|-> pldm_send_component_tables (xxx_send_package_data)
> 		|-> pldm_flash_components (xxx_flash_component)
> 		|-> pldm_finalize_update (xxx_finalize_update)
> 
> Signed-off-by: Shawn Shao <shawn.shao@...uarmicro.com>
> ---


Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>