linux-kernel - Re: [PATCH] bcachefs: return err ptr instead of null in read sb clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <hz3mj5qtutvjddnfhhbeu74hoxu67qzzgwmpxzcldbslsj7fed@53sfkbbxpriq>
Date: Tue, 10 Sep 2024 17:28:55 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Diogo Jahchan Koike <djahchankoike@...il.com>
Cc: syzbot+1cecc37d87c4286e5543@...kaller.appspotmail.com, 
	linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcachefs: return err ptr instead of null in read sb clean

On Tue, Sep 10, 2024 at 06:18:34PM GMT, Diogo Jahchan Koike wrote:
> syzbot reported a null-ptr-deref in bch2_fs_start. [0]
> 
> When a sb is marked clear but doesn't have a clean section
> bch2_read_superblock_clean returns NULL which PTR_ERR_OR_ZERO
> lets through, eventually leading to a null ptr dereference down
> the line. Adjust read sb clean to return an ERR_PTR indicating the
> invalid clean section.
> 
> [0] https://syzkaller.appspot.com/bug?extid=1cecc37d87c4286e5543
> 
> Reported-by: syzbot+1cecc37d87c4286e5543@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=1cecc37d87c4286e5543
> Signed-off-by: Diogo Jahchan Koike <djahchankoike@...il.com>

Thanks, applied