linux-kernel - Re: [PATCH wireless-next v2 3/3] wifi: wlcore: sdio: Use helper to define resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240910215839.GB12725@vamoiridPC>
Date: Tue, 10 Sep 2024 23:58:39 +0200
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: "Khan, Sabeeh" <sabeeh-khan@...com>
Cc: Vasileios Amoiridis <vassilisamir@...il.com>,
	arend.vanspriel@...adcom.com, kvalo@...nel.org, knaerzche@...il.com,
	leitao@...ian.org, linus.walleij@...aro.org, javierm@...hat.com,
	linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
	brcm80211-dev-list.pdl@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH wireless-next v2 3/3] wifi: wlcore: sdio: Use helper to
 define resources

On Mon, Sep 09, 2024 at 01:38:58PM +0400, Khan, Sabeeh wrote:
> Hi Vasileios,
> 
> On 9/4/2024 7:49 PM, Vasileios Amoiridis wrote:
> > Resources definition can become simpler and more organised by
> > using the dedicated helpers.
> >
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> > ---
> >  drivers/net/wireless/ti/wlcore/sdio.c | 11 ++++-------
> >  1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
> > index 9e1b644beba9..a73207bbe5d7 100644
> > --- a/drivers/net/wireless/ti/wlcore/sdio.c
> > +++ b/drivers/net/wireless/ti/wlcore/sdio.c
> > @@ -323,15 +323,12 @@ static int wl1271_probe(struct sdio_func *func,
> >  
> >  	memset(res, 0x00, sizeof(res));
> >  
> > -	res[0].start = irq;
> > -	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> > -	res[0].name = "irq";
> > -
> > +	res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
> > +	res[0].flags |= irq_get_trigger_type(irq);
> >  
> >  	if (wakeirq > 0) {
> > -		res[1].start = wakeirq;
> > -		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
> > -		res[1].name = "wakeirq";
> > +		res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
> > +		res[1].flags |= irq_get_trigger_type(wakeirq);
> >  		num_irqs = 2;
> >  	} else {
> >  		num_irqs = 1;
> 
> Tested-by: Sabeeh Khan <sabeeh-khan@...com>
> Reviewed-by: Sabeeh Khan <sabeeh-khan@...com>
> 

Hi Sabeeh,

Thank you very much!

Cheers,
Vasilis