[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240910220722.GD12725@vamoiridPC>
Date: Wed, 11 Sep 2024 00:07:22 +0200
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: jic23@...nel.org, dan.carpenter@...aro.org, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: iio: pressure: bmp280: Use char instead of s32 for data buffer
On Fri, Aug 23, 2024 at 07:20:17PM +0200, Vasileios Amoiridis wrote:
> As it was reported and discussed here [1], storing the sensor data in an
> endian aware s32 buffer is not optimal. Advertising the timestamp as an
> addition of 2 s32 variables which is also implied is again not the best
> practice. For that reason, change the s32 sensor_data buffer to a char
> buffer with an extra value for the timestamp (as it is common practice).
>
> [1]: https://lore.kernel.org/linux-iio/73d13cc0-afb9-4306-b498-5d821728c3ba@stanley.mountain/
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> ---
> drivers/iio/pressure/bmp280-core.c | 43 +++++++++++++++++-------------
> drivers/iio/pressure/bmp280.h | 5 +++-
> 2 files changed, 28 insertions(+), 20 deletions(-)
>
Hi Jonathan,
I noticed that this patch didn't receive any comments nor applied.
Was this intentional because we wait for something from mainline to
be merged back?
Cheers,
Vasilis
Powered by blists - more mailing lists