linux-kernel - Re: [PATCH] Input: ims-pcu - fix calling interruptible mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuDS9tfekWgHnFsp@google.com>
Date: Tue, 10 Sep 2024 16:15:02 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ims-pcu - fix calling interruptible mutex

On Tue, Sep 10, 2024 at 04:58:47PM -0500, David Lechner wrote:
> Fix calling scoped_cond_guard() with mutex instead of mutex_intr.
> 
> scoped_cond_guard(mutex, ...) will call mutex_lock() instead of
> mutex_lock_interruptible().
> 
> Fixes: 703f12672e1f ("Input: ims-pcu - switch to using cleanup functions")
> Signed-off-by: David Lechner <dlechner@...libre.com>

Applied, thank you.

Too bad it does not warn when incorrect type of guard object is being
used with scoped_cond_guard()...

-- 
Dmitry