linux-kernel - Re: [bug report] block: Non-NCQ commands will never be executed while fio is continuously running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e78cce0-3f4c-3ddf-4d5b-ee2b5c8d7e1a@huawei.com>
Date: Tue, 10 Sep 2024 14:34:06 +0800
From: yangxingui <yangxingui@...wei.com>
To: Damien Le Moal <dlemoal@...nel.org>, <axboe@...nel.dk>, John Garry
	<john.g.garry@...cle.com>
CC: <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<James.Bottomley@...senPartnership.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, <damien.lemoal@...nsource.wdc.com>
Subject: Re: [bug report] block: Non-NCQ commands will never be executed while
 fio is continuously running



On 2024/9/10 12:45, Damien Le Moal wrote:
> On 9/10/24 10:09 AM, yangxingui wrote:
>>
>>
>> On 2024/9/9 21:21, Damien Le Moal wrote:
>>> On 9/9/24 22:10, yangxingui wrote:
>>>> Hello axboe & John,
>>>>
>>>> After the driver exposes all HW queues to the block layer, non-NCQ
>>>> commands will never be executed while fio is continuously running, such
>>>> as a smartctl command.
>>>>
>>>> The cause of the problem is that other hctx used by the NCQ command is
>>>> still active and can continue to issue NCQ commands to the sata disk.
>>>> And the pio command keeps retrying in its corresponding hctx because
>>>> qc_defer() always returns true.
>>>>
>>>> hctx0: ncq, pio, ncq
>>>> hctx1：ncq, ncq, ...
>>>> ...
>>>> hctxn: ncq, ncq, ...
>>>>
>>>> Is there any good solution for this?
>>>
>>> SATA devices are single queue so how can you have multiple queues ?
>>> What adapter are you using ?
>>
>> In the following patch, we expose the host's 16 hardware queues to the block
>> layer. And when connecting to a sata disk, 16 hctx are used.
>>
>> 8d98416a55eb ("scsi: hisi_sas: Switch v3 hw to MQ")
> 
> OK, so the HBA is a hisi one, using libsas...
> What is the device ? An SSD ? and HDD ?
Both SATA SSD and SATA HDD have this problem.

> 
> Do you set a block I/O scheduler for the drive, e.g. mq-deadline. If not, does
> setting a scheduler resolve the issue ?
Currently, the default configuration mq-deadline is used, and the same 
phenomenon occurs when I try setting it to none. It seems to have 
nothing to do with the scheduling strategy.

> 
> I do not have any hisi HBA. I use a lot of mpt3sas and mpi3mr HBAs which also
> have multiple queues with a shared tagset. Never seen the issue you are
> reporting though using HDDs with mq-deadline or bfq as the scheduler.
Unlike libsas, as these hosts don't use qc_defer()?

Thanks,
Xingui
.