linux-kernel - Re: [PATCH v2 00/12] smb: fix some bugs, move duplicate definitions to common header file, and some small cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5muWoAobVc53LLkifZL_hE7bfxU6ZgPH2CAfAWoe-9jJrA@mail.gmail.com>
Date: Tue, 10 Sep 2024 01:36:53 -0500
From: Steve French <smfrench@...il.com>
To: chenxiaosong@...nxiaosong.com
Cc: linkinjeon@...nel.org, sfrench@...ba.org, senozhatsky@...omium.org, 
	tom@...pey.com, linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	pc@...guebit.com, ronniesahlberg@...il.com, sprasad@...rosoft.com, 
	bharathsm@...rosoft.com, chenxiaosong@...inos.cn, liuzhengyuan@...inos.cn, 
	huhai@...inos.cn, liuyun01@...inos.cn
Subject: Re: [PATCH v2 00/12] smb: fix some bugs, move duplicate definitions
 to common header file, and some small cleanups

The following patches from the series have been added to cifs-2.6.git
for-next (the other patches in the series were either for fs/smb/server
rather than the client, or have already been merged).  Let me know
if any objections or problems seen.

d837dec2296c smb: add comment to STATUS_MCA_OCCURED
15dd39d9da2b smb: move SMB2 Status code to common header file
5ce486228d95 smb: move some duplicate definitions to common/smbacl.h
1e4b28faf320 smb/client: rename cifs_ace to smb_ace
664987e5e550 smb/client: rename cifs_acl to smb_acl
624d2ce94277 smb/client: rename cifs_sid to smb_sid
8335848d54c1 smb/client: rename cifs_ntsd to smb_ntsd

On Thu, Aug 22, 2024 at 3:25 AM <chenxiaosong@...nxiaosong.com> wrote:
>
> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>
> Fix some bugs in smb2_open() of smb server.
>
> In order to maintain the code more easily, move some duplicate
> definitions to common header file.
>
> Additionally, add some small cleanups to the patchset.
>
> v1->v2:
>   - update patch #2 according to Namjae's suggestions.
>   - add patch #6~9 to rename 'cifs_ntsd' 'cifs_sid' 'cifs_acl' 'cifs_ace' according to Namjae's suggestions.
>   - add patch #12 to explained why the typo 'STATUS_MCA_OCCURED' was not corrected.
>
> v1: https://lore.kernel.org/all/20240820143319.274033-1-chenxiaosong@chenxiaosong.com/
>
> ChenXiaoSong (12):
>   smb/server: fix return value of smb2_open()
>   smb/server: fix potential null-ptr-deref of lease_ctx_info in
>     smb2_open()
>   smb/server: remove useless assignment of 'file_present' in smb2_open()
>   smb/client: fix typo: GlobalMid_Sem -> GlobalMid_Lock
>   smb/server: update misguided comment of smb2_allocate_rsp_buf()
>   smb/client: rename cifs_ntsd to smb_ntsd
>   smb/client: rename cifs_sid to smb_sid
>   smb/client: rename cifs_acl to smb_acl
>   smb/client: rename cifs_ace to smb_ace
>   smb: move some duplicate definitions to common/smbacl.h
>   smb: move SMB2 Status code to common header file
>   smb: add comment to STATUS_MCA_OCCURED
>
>  fs/smb/client/cifsacl.c                |  224 +--
>  fs/smb/client/cifsacl.h                |   99 +-
>  fs/smb/client/cifsfs.c                 |    6 +-
>  fs/smb/client/cifsglob.h               |   22 +-
>  fs/smb/client/cifsproto.h              |   18 +-
>  fs/smb/client/cifssmb.c                |    6 +-
>  fs/smb/client/smb2file.c               |    2 +-
>  fs/smb/client/smb2inode.c              |    6 +-
>  fs/smb/client/smb2maperror.c           |    2 +-
>  fs/smb/client/smb2misc.c               |    2 +-
>  fs/smb/client/smb2ops.c                |   16 +-
>  fs/smb/client/smb2pdu.c                |   14 +-
>  fs/smb/client/smb2pdu.h                |    8 +-
>  fs/smb/client/smb2proto.h              |    2 +-
>  fs/smb/client/smb2transport.c          |    2 +-
>  fs/smb/client/xattr.c                  |    4 +-
>  fs/smb/{client => common}/smb2status.h |    6 +
>  fs/smb/common/smbacl.h                 |  121 ++
>  fs/smb/server/oplock.c                 |    4 +-
>  fs/smb/server/server.c                 |    2 +-
>  fs/smb/server/smb2misc.c               |    2 +-
>  fs/smb/server/smb2pdu.c                |   17 +-
>  fs/smb/server/smb_common.c             |    2 +-
>  fs/smb/server/smbacl.h                 |  111 +-
>  fs/smb/server/smbstatus.h              | 1822 ------------------------
>  fs/smb/server/transport_rdma.c         |    2 +-
>  26 files changed, 314 insertions(+), 2208 deletions(-)
>  rename fs/smb/{client => common}/smb2status.h (99%)
>  create mode 100644 fs/smb/common/smbacl.h
>  delete mode 100644 fs/smb/server/smbstatus.h
>
> --
> 2.34.1
>
>


-- 
Thanks,

Steve