linux-kernel - Re: [PATCH] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ed5skkh6.fsf@intel.com>
Date: Tue, 10 Sep 2024 10:59:17 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Tejas Vipin <tejasvipin76@...il.com>, Laurent.pinchart@...asonboard.com,
 patrik.r.jakobsson@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
 daniel@...ll.ch
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Tejas
 Vipin <tejasvipin76@...il.com>
Subject: Re: [PATCH] drm/gma500: replace drm_detect_hdmi_monitor() with
 drm_display_info.is_hdmi

On Tue, 10 Sep 2024, Tejas Vipin <tejasvipin76@...il.com> wrote:
> Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since
> monitor HDMI information is available after EDID is parsed. Additionally
> rewrite the code the code to have fewer indentation levels.
>
> Signed-off-by: Tejas Vipin <tejasvipin76@...il.com>
> ---
>  drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_hdmi.c b/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> index 2d95e0471291..cfbf3137e144 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> @@ -135,16 +135,16 @@ static enum drm_connector_status cdv_hdmi_detect(
>  
>  	hdmi_priv->has_hdmi_sink = false;
>  	hdmi_priv->has_hdmi_audio = false;
> -	if (edid) {
> -		if (edid->input & DRM_EDID_INPUT_DIGITAL) {
> -			status = connector_status_connected;
> -			hdmi_priv->has_hdmi_sink =
> -						drm_detect_hdmi_monitor(edid);
> -			hdmi_priv->has_hdmi_audio =
> -						drm_detect_monitor_audio(edid);
> -		}
> -		kfree(edid);
> +	if (!edid)
> +		return status;
> +
> +	if (edid->input & DRM_EDID_INPUT_DIGITAL) {
> +		status = connector_status_connected;
> +		hdmi_priv->has_hdmi_sink = connector->display_info.is_hdmi;
> +		hdmi_priv->has_hdmi_audio = drm_detect_monitor_audio(edid);

display_info.has_audio

>  	}
> +	kfree(edid);
> +

Please switch the code to use struct drm_edid and the related functions
drm_edid_read(), drm_edid_connector_update() and
drm_edid_connector_add_modes() while you're at it. See git log
--grep=drm_edid for a number of examples.

BR,
Jani.


>  	return status;
>  }

-- 
Jani Nikula, Intel